Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): build with --locked flag #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Dec 19, 2023

$ cargo test -h | rg 'locked'

--locked                Require Cargo.lock is up to date

So that we can avoid #114 from happening 馃惢

@orhun orhun marked this pull request as draft December 19, 2023 17:00
@orhun
Copy link
Contributor Author

orhun commented Dec 19, 2023

Ok I realized kondo-ui tests are not being run with this workflow since it is excluded from the workspace - is there any other CI checks that we can integrate --locked?

@tbillington
Copy link
Owner

Yep, I had to remove kondo-ui from the workspace by default because it had different build requirements and at the time I didn't consider it important enough to resolve for CI builds.

Potentially the cross build could use it?

I think the github CI in kondo could be improved, it also uses some deprecated actions that throws warnings when it runs.

@orhun orhun changed the title chore: use --locked flag while executing tests chore(ci): build with --locked flag Dec 21, 2023
@orhun
Copy link
Contributor Author

orhun commented Dec 21, 2023

Potentially the cross build could use it?

Makes sense, updated the PR!

I think the github CI in kondo could be improved, it also uses some deprecated actions that throws warnings when it runs.

I also realized that and I think I can help improving it. Do you want me to create an issue for tracking and follow up with a PR?

@orhun orhun marked this pull request as ready for review December 21, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants