Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation work; added platform-specific notes for nix #990

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

pelasgus
Copy link

…v env via nix for rust dev.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@pelasgus pelasgus requested a review from a team as a code owner July 24, 2023 11:46
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pelasgus and others added 4 commits July 26, 2023 19:55
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Only packages related to repository

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@pelasgus
Copy link
Author

Implemented all requested changes; pending approval.

README.md Show resolved Hide resolved
- Added libappindicator-gtk3 & libayatana-indicator
Fixed libayatana
@amrbashir
Copy link
Member

Oh looks like you didn't sign your first commit and I can't merge the PR unless all commits are signed. You need to setup commit signing, then you can sign past commit like this for example.

@pelasgus
Copy link
Author

@amrbashir just merge this anyway, your commits cannot be fully verified, its you and my original commit that are blocking merge. Please rectify, cheers

@amrbashir
Copy link
Member

Partially verified commits are fine, but you have one commit at the beginning of the PR that is not verified.
image

You can try squashing all commits into one verified commit or close this PR and re-open a new one.

Otherwise our guidelines and repo configuration prevents anyone from bypassing this requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants