Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cross compilation from macOS #498

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Fixes an issue when cross compiling cargo build --target x86_64-pc-windows-gnu on macOS systems, since we can't use #[cfg()] to link the WebKit framework as that checks the system target instead of the runtime selected one.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
primeos Michael Weiss
@lucasfernog lucasfernog requested a review from a team as a code owner February 15, 2022 02:30
@wusyong wusyong merged commit c97499f into dev Feb 15, 2022
@wusyong wusyong deleted the fix/cross-compilation-macos branch February 15, 2022 04:26
@github-actions github-actions bot mentioned this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants