Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds monitor_from_point method #9770

Merged
merged 14 commits into from
May 14, 2024
Merged

feat: adds monitor_from_point method #9770

merged 14 commits into from
May 14, 2024

Conversation

clearlysid
Copy link
Contributor

@clearlysid clearlysid commented May 14, 2024 •
edited

Exposes this Tao method in Tauri too. Merging this closes #3057 and unblocks spyglass-search/spyglass#312

@clearlysid
Copy link
Contributor Author

If someone can guide me to resolve the above comments, this PR will be ready to review 💫

@clearlysid clearlysid marked this pull request as ready for review May 14, 2024 03:07
@clearlysid clearlysid requested a review from a team as a code owner May 14, 2024 03:07
amrbashir
amrbashir requested changes May 14, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, LGTM, just need to get the documentation consistent and should be good to go. You also need to run yarn build and yarn format inside tooling/api

core/tauri-runtime/src/lib.rs Outdated Show resolved Hide resolved
core/tauri/src/app.rs Outdated Show resolved Hide resolved
core/tauri/src/webview/webview_window.rs Outdated Show resolved Hide resolved
core/tauri/src/window/mod.rs Outdated Show resolved Hide resolved
tooling/api/src/window.ts Outdated Show resolved Hide resolved
@clearlysid clearlysid requested a review from amrbashir May 14, 2024 16:30
@clearlysid
Copy link
Contributor Author

All good from my end ✅

amrbashir
amrbashir previously approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

amrbashir
amrbashir reviewed May 14, 2024
View reviewed changes
core/tauri/src/app.rs Outdated Show resolved Hide resolved
clearlysid and others added 14 commits May 14, 2024 19:42
@clearlysid @amrbashir
feat: adds monitor_from_point function
9de6930
@clearlysid @amrbashir
temp: need help passing around coordinates
f88e004
@clearlysid @amrbashir
fix: window plugin command
b9cae38
@clearlysid @amrbashir
fix: correctly pass coordinates to WindowMessage
515f54f
@clearlysid @amrbashir
style: move monitor_from_point to end of list
7ef502e
@clearlysid @amrbashir
feat: documents changes
98ccadd
@clearlysid @amrbashir
fix: Number -> number ts type. resolves a failing test.
3201429 
Signed-off-by: clearlysid <siddharth99c@gmail.com>
@clearlysid @amrbashir
docs: make consistent
cf737a4 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@clearlysid @amrbashir
docs: make consistent
a6bb1d5 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@clearlysid @amrbashir
docs: make consistent
d5e36c7 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@clearlysid @amrbashir
docs: make consistent
d02c2ee 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@clearlysid @amrbashir
docs: make consistent
07b6b3e 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@clearlysid @amrbashir
feat: bundle and format
ba3f4de
@amrbashir
Update core/tauri/src/app.rs
6222f0e
@clearlysid
Copy link
Contributor Author

clearlysid commented May 14, 2024 •
edited

wow how'd you do this? here I thought I needed to go back and re-commit each one again with signature 😂 — nice work!

@amrbashir
Copy link
Member

Check this for the command I use https://superuser.com/questions/397149/can-you-gpg-sign-old-commits/1123928#1123928

@amrbashir amrbashir merged commit ec0e092 into tauri-apps:dev May 14, 2024
22 of 24 checks passed
@clearlysid clearlysid deleted the feat/monitor-from-point branch May 15, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Monitor::from_point and Monitor::cursor_position
2 participants
@clearlysid @amrbashir