Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy errors on macOS #7064

Merged
merged 2 commits into from May 26, 2023
Merged

fix clippy errors on macOS #7064

merged 2 commits into from May 26, 2023

Conversation

chippers
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

We should have clippy run on windows and macOS too, since there is a lot of platform specific code

@chippers chippers requested a review from a team as a code owner May 26, 2023 06:06
@wusyong wusyong merged commit 1604894 into next May 26, 2023
24 checks passed
@wusyong wusyong deleted the fix/clippy-macos branch May 26, 2023 07:24
@wusyong wusyong restored the fix/clippy-macos branch May 26, 2023 07:24
@chippers chippers deleted the fix/clippy-macos branch May 26, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

None yet

2 participants