Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cargo workspace package table #6885

Merged
merged 5 commits into from
May 26, 2023
Merged

Conversation

chippers
Copy link
Member

@chippers chippers commented May 6, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

We can use the Cargo Workspace Package Table in order to set the same values that are used for many [package] keys in most packages. I think we could also use this for tooling and examples, but we need to figure out how we want to structure the workspace before that.

@chippers chippers requested a review from a team as a code owner May 6, 2023 20:17
@chippers chippers marked this pull request as draft May 6, 2023 20:19
@chippers chippers self-assigned this May 6, 2023
@chippers chippers force-pushed the feat/cargo-workspace-package-table branch from c57511f to 5db4810 Compare May 6, 2023 20:41
@chippers chippers marked this pull request as ready for review May 6, 2023 20:42
@chippers chippers marked this pull request as draft May 6, 2023 20:53
@chippers
Copy link
Member Author

chippers commented May 6, 2023

@FabianLars will this also run into the problem you described in #6842 (comment)?

@FabianLars
Copy link
Member

FabianLars commented May 6, 2023

Yeah, covector will convert the syntax to

  [package.authors]
  workspace = true

and will remove the comment.

Edit: covector seems to rewrite the whole file and not just the parts it actually has to modify.

@lucasfernog
Copy link
Member

I actually had to use the dep = { workspace = true } syntax instead of dep.workspace = true to not get that ugly format from covector.

@chippers
Copy link
Member Author

Unfortunate, is this a problem with covector or a dependency of it? Is this tracked somewhere?

@chippers chippers marked this pull request as ready for review May 26, 2023 08:37
@lucasfernog
Copy link
Member

It's a problem with https://github.com/tauri-apps/tauri-toml @chippers

@lucasfernog
Copy link
Member

lucasfernog commented May 26, 2023

I'll see if updating the fork fixes it.
EDIT: nope, no easy way to adjust it :(

@lucasfernog lucasfernog merged commit 7fee3d3 into next May 26, 2023
24 checks passed
@lucasfernog lucasfernog deleted the feat/cargo-workspace-package-table branch May 26, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

None yet

3 participants