-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove lto setting from CLI #6861
Conversation
what do you think about moving the lto (and the new stuff you added in the js api) into a custom profile that inherits the release profile so that we can use that for the cargo-binstall CI? |
I had to use patch-package because napi-rs does not support custom profiles :( |
Also @JonasKruckenberg why did you target |
I would probably look into upstreaming this to Also if I understand correctly, this change wants to improve |
He's focusing on v3 so I'm not sure if he wants to patch for v2. I'll try anyway. |
I think you misunderstood. We don't want users to use |
ah right, I was even more confused by the name. LGTM then. |
@CrabNejonas we also need to rebase this branch with commit signing 😢 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
This PR removes the
lto=true
setting for the CLI. This drastically improves the install performance (the time it takes to runcargo install tauri-cli
).Since the CLI is not doing performance-critical work and size is not important here since the cli will be compiled locally this does not have a downside it it afaik and only improves performance for rust users.
To give you an idea here are the install times on my MacBook Pro m2:
so as you can see disabling lto reduced the compile-time by 3x.