New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bench): Result interpretation problems #5798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a newer syscall interface and gets counted seperately in strace results.
The column offsets didn't match up when usecs/call is included in the totals.
On my local machine, it used an NL locale changing the strace numbers to use commas. Adding this env var avoids that problem.
This don't yet fix #5800 The ubuntu update also caused issues with the strace output being different. |
This reverts commit 0a9d995.
The benchmark result can be seen here: Restoring the syscalls and thread count to expected range. {
"created_at": "2022-12-09T14:37:49Z",
"sha1": "0a9d99551dbdc49ba5945ec896804b7870dc853f",
"exec_time": {
"tauri_3mb_transfer": {
"stddev": 4.31788653464092,
"system": 0.10376614,
"min": 13.783955114655,
"user": 0.269474715,
"max": 25.774074237655,
"mean": 23.755779372855
},
"tauri_hello_world": {
"max": 25.362370100655,
"system": 0.026286739999999996,
"user": 0.068088815,
"min": 18.948130902655,
"mean": 24.050229535955,
"stddev": 2.6422230777400255
},
"tauri_cpu_intensive": {
"min": 5.8631193956550005,
"mean": 24.935138477455,
"stddev": 10.047903412326082,
"max": 29.713699274655,
"system": 0.04284094,
"user": 0.102933015
}
},
"binary_size": {
"tauri_3mb_transfer": 1863568,
"wry_rlib": 705990,
"tauri_cpu_intensive": 1863472,
"tauri_hello_world": 1863464
},
"max_memory": {
"tauri_hello_world": 277872640,
"tauri_cpu_intensive": 407896064,
"tauri_3mb_transfer": 512753664
},
"thread_count": {
"tauri_cpu_intensive": 53,
"tauri_hello_world": 48,
"tauri_3mb_transfer": 49
},
"syscall_count": {
"tauri_cpu_intensive": 32445,
"tauri_hello_world": 25991,
"tauri_3mb_transfer": 26341
},
"cargo_deps": {
"macOS": 210,
"Windows": 212,
"Linux": 230
}
} |
This was referenced Dec 9, 2022
lucasfernog
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
The main reason the benchmarks broke / went weird, were because of
ubuntu-latest
changing from 20.04 to 22.04.This PR fixes the interpretation of results. But doesn't address the performance regression in #5800.
fix(bench): Include clone3 in thread count
It's a newer syscall interface and gets counted seperately in strace results.
fix(bench): Update totals line parsing
The column offsets didn't match up when usecs/call is included in the totals.
fix(bench): Enforce locale, avoiding parse errors
On my local machine, it used an NL locale changing the strace numbers to use commas.
Adding this env var avoids that problem.