New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundler): add nsis
, closes #4450, closes #2319
#4674
Conversation
You made it look easy @amrbashir let me know if I did something wrong. Let's merge this tomorrow ❤️ |
There are two features I was hoping to address before merge:
I will see if I can finish them tomorrow, if not, I can add them later in another PR. |
We can add it later too no problem. |
Sure go ahead and merge if you want, I will add the missing features laeter. |
took me a lot of trials and errors and workarounds but |
Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
TODOs: