Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): add nsis, closes #4450, closes #2319 #4674

Merged
merged 50 commits into from Jan 3, 2023
Merged

feat(bundler): add nsis, closes #4450, closes #2319 #4674

merged 50 commits into from Jan 3, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 15, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

TODOs:

  • resources
  • external binaries
  • set AppUserModelID for notifications, jumplists, grouping...etc
  • downgrades and upgrades
  • Webview2 install modes
  • Prompt to kill if the app is running
  • updater package
  • change file
  • deep link

@amrbashir amrbashir marked this pull request as ready for review July 18, 2022 15:29
@amrbashir amrbashir requested a review from a team as a code owner July 18, 2022 15:29
@amrbashir amrbashir linked an issue Sep 30, 2022 that may be closed by this pull request
@amrbashir amrbashir changed the base branch from dev to next October 31, 2022 23:36
@amrbashir amrbashir changed the base branch from next to dev November 4, 2022 12:33
@lucasfernog
Copy link
Member

You made it look easy @amrbashir let me know if I did something wrong. Let's merge this tomorrow ❤️

@amrbashir
Copy link
Member Author

amrbashir commented Dec 15, 2022

There are two features I was hoping to address before merge:

  • Removing the version limitation and allow 1.0.0-alpha.1
  • Add combined install modes

I will see if I can finish them tomorrow, if not, I can add them later in another PR.

@lucasfernog
Copy link
Member

We can add it later too no problem.

@amrbashir
Copy link
Member Author

Sure go ahead and merge if you want, I will add the missing features laeter.

@amrbashir
Copy link
Member Author

took me a lot of trials and errors and workarounds but both modes are finally supported. This PR is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perUser InstallScope
4 participants