Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tauri-build): add option to specify Windows manifest, closes #5584 #5730

Merged
merged 5 commits into from Dec 14, 2022
Merged

feat(tauri-build): add option to specify Windows manifest, closes #5584 #5730

merged 5 commits into from Dec 14, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner November 30, 2022 15:37
@CaptainIsaaca

This comment was marked as off-topic.

Sign in to view
FabianLars
FabianLars previously approved these changes Dec 14, 2022
View reviewed changes
Copy link
Sponsor Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cli change file doesn't exist anymore so. The pr itself works fine :)

@lucasfernog lucasfernog merged commit bca09f7 into dev Dec 14, 2022
@lucasfernog lucasfernog deleted the feat/windows-manifest branch December 14, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@FabianLars FabianLars FabianLars left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amrbashir @CaptainIsaaca @lucasfernog @FabianLars