Skip to content

Commit

Permalink
chore(deps): remove unused deps from cli (#9711)
Browse files Browse the repository at this point in the history
* chore(deps): remove unused deps from cli

* fix mac build

* clippy
  • Loading branch information
amrbashir committed May 9, 2024
1 parent 6968c40 commit caec19f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 22 deletions.
3 changes: 0 additions & 3 deletions tooling/cli/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions tooling/cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ jsonrpsee = { version = "0.22", features = [ "server" ] }
jsonrpsee-core = "0.22"
jsonrpsee-client-transport = { version = "0.22", features = [ "ws" ] }
jsonrpsee-ws-client = { version = "0.22", default-features = false }
thiserror = "1"
sublime_fuzzy = "0.7"
clap_complete = "4"
clap = { version = "4.5", features = [ "derive", "env" ] }
Expand All @@ -71,8 +70,6 @@ ureq = { version = "2.9.6", default-features = false, features = [ "gzip" ] }
os_info = "3"
semver = "1.0"
regex = "1.10.3"
unicode-width = "0.1"
zeroize = "1.7"
heck = "0.5"
dialoguer = "0.11"
url = { version = "2.5", features = [ "serde" ] }
Expand Down
12 changes: 3 additions & 9 deletions tooling/cli/src/mobile/android/dev.rs
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ fn run_dev(
}
Err(e) => {
crate::dev::kill_before_dev_process();
Err(e.into())
Err(e)
}
}
} else {
Expand All @@ -279,20 +279,14 @@ fn run_dev(
)
}

#[derive(Debug, thiserror::Error)]
enum RunError {
#[error("{0}")]
RunFailed(String),
}

fn run(
device: &Device<'_>,
options: MobileOptions,
config: &AndroidConfig,
env: &Env,
metadata: &AndroidMetadata,
noise_level: NoiseLevel,
) -> Result<DevChild, RunError> {
) -> crate::Result<DevChild> {
let profile = if options.debug {
Profile::Debug
} else {
Expand All @@ -317,5 +311,5 @@ fn run(
".MainActivity".into(),
)
.map(DevChild::new)
.map_err(|e| RunError::RunFailed(e.to_string()))
.map_err(Into::into)
}
9 changes: 2 additions & 7 deletions tooling/cli/src/mobile/ios/dev.rs
Original file line number Diff line number Diff line change
Expand Up @@ -244,17 +244,12 @@ fn run_dev(
)
}

#[derive(Debug, thiserror::Error)]
enum RunError {
#[error("{0}")]
RunFailed(String),
}
fn run(
device: &Device<'_>,
options: MobileOptions,
config: &AppleConfig,
env: &Env,
) -> Result<DevChild, RunError> {
) -> crate::Result<DevChild> {
let profile = if options.debug {
Profile::Debug
} else {
Expand All @@ -270,5 +265,5 @@ fn run(
profile,
)
.map(DevChild::new)
.map_err(|e| RunError::RunFailed(e.to_string()))
.map_err(Into::into)
}

0 comments on commit caec19f

Please sign in to comment.