fix(updater): escape MSI path (#4737)

tauri-apps · Jul 22, 2022 · 9af4313 · 9af4313
1 parent 635f23b
commit 9af4313
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.changes/fix-windows-updater.md b/.changes/fix-windows-updater.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+Escape the MSI file path when running msiexec via powershell.
diff --git a/core/tauri/src/updater/core.rs b/core/tauri/src/updater/core.rs
@@ -789,6 +789,12 @@ fn copy_files_and_run<R: Read + Seek>(
       current_exe_arg.push("\"");
       current_exe_arg.push(current_exe()?);
       current_exe_arg.push("\"");
+
+      let mut msi_path_arg = std::ffi::OsString::new();
+      msi_path_arg.push("\"\"\"");
+      msi_path_arg.push(&found_path);
+      msi_path_arg.push("\"\"\"");
+
       // run the installer and relaunch the application
       let powershell_install_res = Command::new("powershell.exe")
         .args(["-NoProfile", "-windowstyle", "hidden"])
@@ -800,7 +806,7 @@ fn copy_files_and_run<R: Read + Seek>(
           "-ArgumentList",
         ])
         .arg("/i,")
-        .arg(&found_path)
+        .arg(msi_path_arg)
         .arg(format!(", {}, /promptrestart;", msiexec_args.join(", ")))
         .arg("Start-Process")
         .arg(current_exe_arg)