Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app size documentation #2143

Merged
merged 5 commits into from
May 20, 2024
Merged

Conversation

simonhyll
Copy link
Sponsor Contributor

@simonhyll simonhyll commented May 13, 2024

Adds some thoughts on Cargo.toml configuration for improving app size.

@simonhyll simonhyll requested a review from a team as a code owner May 13, 2024 15:32
Copy link

netlify bot commented May 13, 2024

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8af6518
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/664bded1addf32000837ac61
😎 Deploy Preview https://deploy-preview-2143--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@simonhyll simonhyll requested a review from vasfvitor May 20, 2024 22:30
fix: texts

fix: text

fix: formatting

fix: merge notice asides

fix: rpath description

fix: minor edits
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp, it took me a while to understand the features section, I glanced over the note, then I read it, and only later after checking the config in rust docs was that I understood the note.

config codeblock

take a time to read about the impact of these options at profile.release as they may impact in so and so... make sure .... and done

@simonhyll
Copy link
Sponsor Contributor Author

I'll restructure it to be a shorter and sweeter version I guess.

@simonhyll simonhyll merged commit 98f5e2f into tauri-apps:v2 May 20, 2024
3 checks passed
@simonhyll simonhyll deleted the feat/app-size branch May 20, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants