Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/search no results #1900

Open
wants to merge 9 commits into
base: v2
Choose a base branch
from

Conversation

simonhyll
Copy link
Sponsor Contributor

@simonhyll simonhyll commented Feb 29, 2024

Based on my PR for Awesome Tauri.

#1873

@simonhyll simonhyll added this to the Version 2.x milestone Feb 29, 2024
@simonhyll simonhyll self-assigned this Feb 29, 2024
@simonhyll simonhyll requested a review from a team as a code owner February 29, 2024 16:52
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fe2512e
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65e78b4226b6bd000870d746
😎 Deploy Preview https://deploy-preview-1900--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@vasfvitor
Copy link
Contributor

When there's no results, the scrollbar disappears and cause the page to shift horizontally

@simonhyll
Copy link
Sponsor Contributor Author

When there's no results, the scrollbar disappears and cause the page to shift horizontally

Nothing can be done about that, the reason it disappears and the page shifts horizontally is because the page simply isn't long enough anymore to warrant one. You'd have to make more content for the page

@vasfvitor
Copy link
Contributor

vasfvitor commented Mar 5, 2024

For me having "have something to share" at the top make it looks odd. Also it is in different positions based on the result


I guess that ideally it should be fixed at the very bottom of the results.

Or maybe just remove this from the "Community Resource" section and put above the search bar on prime real state haha. Could be just a aside, just to give it a flair. Not sure, just thinking out written

@simonhyll simonhyll added the enhancement Does it add or improve content? label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content?
Projects
Status: 📋 In review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants