-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Compatilibity component #1881
base: v2
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tauri-docs-starlight ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
CanIuse sample json, if need something alike. For now I created a JSON with all the plugins and modified the component api to match the <CompatList plugin="authenticator" /> So there's no need to make changer per page, one json to rule them all |
Are we gonna use icons? As of now I think it's ok to be reviewed. The JSON was made from the workspace/v2 table About accessibility, is there any improvements that could be done? |
--- | ||
|
||
<div class="flex row not-content"> | ||
{platforms.map((platform) => <p>{platform}</p>)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that adding the icon next to the name/platform would be even better, what you guys think? @tauri-apps/wg-doc
OUTDATED read next comments
Opening this PR just so it can be seen live. I think this components could be like the "plugin links" that accepts the name of plugin as a prop and that's it. Example
<PluginLinks plugin="clipboard-manager" />
.In this PR there are two versions of the compatibility component that implements Amr and Simon ideas, respectively:
Showing Linux distros inline:
Sample pages:
features/authenticator
,features/autostart
andfeatures/barcode-scanner
Showing Linux distros in a tooltip, if necessary (needs to make mobile accessible):
Sample pages:
features/cli
andfeatures/clipboard
Aesthetically both can be improved, even more the tooltip by using JS (which I don't think should be done). Plus, neither version is supposed to be the definitive or the only possibles implementation of this feature
TODO: Take in account feedback sent by AlmostSenselessCoder in discord
https://discord.com/channels/616186924390023171/662624589037436928/1211237670110629978
TODO: Rename component
TODO: Consider icons