Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrates i18ntracker to Lunaria #1854

Closed
wants to merge 8 commits into from

Conversation

dreyfus92
Copy link
Member

@dreyfus92 dreyfus92 commented Feb 13, 2024

What kind of changes does this PR include?

  • Changes to the docs site code

Description

  • What does this PR change? Give us a brief description.
    Migrates i18ntracker package to use lunaria as default. This will offload maintenance of the i18ntracker and enhance a bit more the the current state of the tracker's UI.

Note

Encountered an issue where Lunaria couldn't track the git history of certain files used in generating Tauri documentation. This is due to these files being fetched via a git submodule, which isn't reflected in the project's main git history.

Implemented a temporary fix in the Lunaria config to bypass this issue:

"ignore": [
  "src/content/docs/references/{v1,v2}/(js/**/*|config).{md,mdx}"
]

This change prevents Lunaria from tracking these files, thus avoiding the error. We'll explore a more permanent solution that maintains the necessary git history for seamless documentation generation in the future.

  • Did you change something visual? A before/after screenshot can be helpful.
Before After
Before After

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a05ff97
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65cbfeeaa0f9af0008279758
😎 Deploy Preview https://deploy-preview-1854--tauri-docs-starlight.netlify.app/contribute/translate-status
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

socket-security bot commented Feb 13, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lunariajs/core@0.0.28 Transitive: environment, filesystem, shell, unsafe +33 4.6 MB yanthomasdev

View full report↗︎

@simonhyll simonhyll added this to the Version 2.0 milestone Feb 26, 2024
@dreyfus92 dreyfus92 added the enhancement Does it add or improve content? label Feb 28, 2024
@simonhyll simonhyll requested a review from a team February 29, 2024 00:59
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the "Translations that need reviews" section missing?
PR:
https://deploy-preview-1854--tauri-docs-starlight.netlify.app/contribute/translate-status/
Broken anchor: "existing Tauri Docs PRs"

Current:
https://beta.tauri.app/contribute/translate-status

Other than that LGTM!

@GuoJikun
Copy link
Contributor

GuoJikun commented Apr 8, 2024

Are there any new developments? The current i18n page display is incomplete.
I gave it a try in a local environment. Screenshot below

af

@dreyfus92
Copy link
Member Author

@GuoJikun, we're still waiting to handle most of the missing docs and current structure to handle this one.

@dreyfus92
Copy link
Member Author

Gonna close this to migrate it to the new version of the docs.

@dreyfus92 dreyfus92 closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content?
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants