Skip to content

Commit

Permalink
Return null coverage for Node.js and output symbol in stats (br…
Browse files Browse the repository at this point in the history
…owserslist#439)

* Simplify a temporary object with browser versions

* Node.js version should return `null` instead `0`

* Add output `—` for Node.js versions with `null` coverage

* Rename `browsersByQueryCoverage` to `browsersCoverageByQuery`
  • Loading branch information
sashachabin committed Aug 19, 2022
1 parent 159cc9f commit db213ad
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 13 deletions.
3 changes: 2 additions & 1 deletion client/view/BrowserStats/browserStats.js
Expand Up @@ -44,7 +44,8 @@ export function toggleShowStats(isShown) {
}

function createCoverageCell(coverage) {
let coveragePercentageHtmlString = cov => formatPercent(cov)
let coveragePercentageHtmlString = cov =>
cov !== null ? formatPercent(cov) : '—'
let coveragePercentageCssString = cov => {
let result = (Math.log(1 + cov) * 100) / Math.log(1 + 100)
if (result === 0) {
Expand Down
27 changes: 15 additions & 12 deletions server/lib/get-browsers.js
Expand Up @@ -20,29 +20,32 @@ export default async function getBrowsers(query, region) {
: new Error(`Unknown browser query \`${query}\`.`)
}

let browsersNames = {}
let browsersCoverageByQuery = {}

for (let browser of browsersByQuery) {
let [id, version] = browser.split(' ')
let versionCoverage = null
let versionCoverage

if (id !== 'node') {
versionCoverage =
// The Node.js is not in the Can I Use db
if (id === 'node') {
versionCoverage = null
} else {
versionCoverage = roundNumber(
region === REGION_GLOBAL
? getGlobalCoverage(id, version)
: await getRegionCoverage(id, version, region)
)
}

let versionData = { [`${version}`]: roundNumber(versionCoverage) }

if (!browsersNames[id]) {
browsersNames[id] = { versions: versionData }
} else {
Object.assign(browsersNames[id].versions, versionData)
if (!browsersCoverageByQuery[id]) {
browsersCoverageByQuery[id] = {}
}

browsersCoverageByQuery[id][version] = versionCoverage
}

let browsers = Object.entries(browsersNames)
.map(([id, { versions }]) => {
let browsers = Object.entries(browsersCoverageByQuery)
.map(([id, versions]) => {
let name
let coverage

Expand Down

0 comments on commit db213ad

Please sign in to comment.