Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): clarify/simplify test setup #2558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AIexanderDicke
Copy link

  • Adds script to copy rawScripts to be used by the python package
  • Simplify setting up the python tests
  • redis-cli not needed in order to cleanup redis before starting tests

Adds script to copy rawScripts to be used by the python package, simplify setting up the python
tests, no need to have `redis-cli` installed in order to cleanup redis before starting tests
@manast
Copy link
Contributor

manast commented May 17, 2024

Thanks for the PR. I wonder, when is copy_scripts.py supposed to be called?

@AIexanderDicke
Copy link
Author

@manast This script should be called before running the tests. You could also add the command to run_tests.sh, but I didn't want to change the functionality of this script.

@manast
Copy link
Contributor

manast commented May 23, 2024

I think if generating the scripts is necessary to make sure the tests are running with the latest lua script, it should be called in run_tests.sh. What do you think @roggervalf ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants