Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker): add ready event #1577

Merged
merged 1 commit into from Dec 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/classes/worker.ts
Expand Up @@ -113,6 +113,13 @@ export interface WorkerListener<
progress: number | object,
) => void;

/**
* Listen to 'ready' event.
*
* This event is triggered when blockingConnection is ready.
*/
ready: () => void;

/**
* Listen to 'resumed' event.
*
Expand Down Expand Up @@ -167,7 +174,7 @@ export class Worker<
string
>;

static RateLimitError() {
static RateLimitError(): Error {
return new Error(RATE_LIMIT_ERROR);
}

Expand Down Expand Up @@ -223,6 +230,7 @@ export class Worker<
this.emit('error', <Error>error);
}
}
this.emit('ready');
});

if (processor) {
Expand Down
26 changes: 20 additions & 6 deletions tests/test_getters.ts
Expand Up @@ -48,15 +48,21 @@ describe('Jobs getters', function () {
describe('.getWorkers', () => {
it('gets all workers for this queue only', async function () {
const worker = new Worker(queueName, async () => {}, { connection });
await worker.waitUntilReady();
await delay(10);
await new Promise<void>(resolve => {
worker.on('ready', () => {
resolve();
});
});

const workers = await queue.getWorkers();
expect(workers).to.have.length(1);

const worker2 = new Worker(queueName, async () => {}, { connection });
await worker2.waitUntilReady();
await delay(10);
await new Promise<void>(resolve => {
worker2.on('ready', () => {
resolve();
});
});

const nextWorkers = await queue.getWorkers();
expect(nextWorkers).to.have.length(2);
Expand All @@ -69,9 +75,17 @@ describe('Jobs getters', function () {
const queueName2 = `${queueName}2`;
const queue2 = new Queue(queueName2, { connection });
const worker = new Worker(queueName, async () => {}, { connection });
await new Promise<void>(resolve => {
worker.on('ready', () => {
resolve();
});
});
const worker2 = new Worker(queueName2, async () => {}, { connection });
await worker.waitUntilReady();
await worker2.waitUntilReady();
await new Promise<void>(resolve => {
worker2.on('ready', () => {
resolve();
});
});

const workers = await queue.getWorkers();
expect(workers).to.have.length(1);
Expand Down