chore: Fix syntax checking to include run-task file #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is another example of the GH integration behaving different from local commit hooks. |
ahal
approved these changes
Jun 23, 2023
pyproject.toml
Outdated
| @@ -26,6 +27,14 @@ ignore = [ | |||
| "E741", | |||
| ] | |||
| target-version = "py37" | |||
| exclude = [ | |||
| "src/taskgraph/run-task/robustcheckout.py", | |||
| "taskcluster/scripts/external_tools/tooltool.py", | |||
There was a problem hiding this comment.
Maybe we should just exclude all of external_tools as presumably we wouldn't want to lint anything in there.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 58.65% 58.65%
=======================================
Files 69 69
Lines 6301 6301
Branches 1269 1269
=======================================
Hits 3696 3696
Misses 2328 2328
Partials 277 277
☔ View full report in Codecov by Sentry. |
hneiva
force-pushed
the
hneiva/syntax-check-fix
branch
from
d5d0186
to
9d1f159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.