feat(ui): Worker Manager shows worker page properly when queue data is missing #7015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotas
requested review from
petemoore and
matt-boris
and removed request for
a team
When only worker-manager data is available, page no longer shows error and gives 404, but displays available info
matt-boris
approved these changes
May 15, 2024
Comment on lines
+430
to
+443
| tooltipTitle="Terminate Worker" | ||
| onClick={() => | ||
| this.handleTerminateDialogActionOpen( | ||
| worker.workerId, | ||
| worker.workerGroup, | ||
| worker.workerPoolId | ||
| ) | ||
| } | ||
| FabProps={{ | ||
| disabled: terminateDisabled( | ||
| worker.state, | ||
| worker.providerId | ||
| ), | ||
| }} | ||
| /> | ||
| )} | ||
| {worker.actions.map(action => ( | ||
| <SpeedDialAction | ||
| requiresAuth | ||
| tooltipOpen | ||
| key={action.title} | ||
| icon={<HammerIcon />} | ||
| onClick={() => this.handleActionDialogOpen(action)} | ||
| FabProps={{ | ||
| disabled: actionLoading, | ||
| }} | ||
| tooltipTitle={action.title} | ||
| /> | ||
| ))} | ||
| </SpeedDial> | ||
| {dialogOpen && | ||
| (selectedAction ? ( | ||
| <DialogAction | ||
| error={dialogError} | ||
| open={dialogOpen} | ||
| title={`${selectedAction.title}?`} | ||
| body={selectedAction.description} | ||
| confirmText={selectedAction.title} | ||
| onSubmit={this.handleWorkerContextActionSubmit} | ||
| onError={this.handleActionError} | ||
| onClose={this.handleDialogClose} | ||
| /> | ||
| ) : ( | ||
| <DialogAction | ||
| error={dialogError} | ||
| open={dialogOpen} | ||
| title="Quarantine?" | ||
| body={ | ||
| <Fragment> | ||
| <Fragment> | ||
| Quarantining a worker allows the machine to remain | ||
| alive but not accept jobs. Note that a quarantine can | ||
| be lifted by setting "Quarantine Until" to | ||
| the present time or somewhere in the past. | ||
| </Fragment> | ||
| <br /> | ||
| <br /> | ||
| <TextField | ||
| id="date" | ||
| label="Quarantine Until" | ||
| type="date" | ||
| value={format(quarantineUntilInput, 'yyyy-MM-dd')} | ||
| onChange={this.handleQuarantineChange} | ||
| /> | ||
| <br /> | ||
| <TextField | ||
| id="info" | ||
| label="Quarantine comment" | ||
| type="text" | ||
| fullWidth | ||
| value={quarantineInfo} | ||
| onChange={this.handleQuarantineInfoChange} | ||
| /> | ||
| </Fragment> | ||
| } | ||
| confirmText={ | ||
| worker.quarantineUntil ? 'Update' : 'Quarantine' | ||
| } | ||
| onSubmit={this.handleQuarantineDialogSubmit} | ||
| onError={this.handleActionError} | ||
| onComplete={this.handleDialogClose} | ||
| onClose={this.handleDialogClose} | ||
| /> | ||
| ))} | ||
| {terminateDialogOpen && ( | ||
| <DialogAction | ||
| error={terminateDialogError} | ||
| open={terminateDialogOpen} | ||
| title={terminateDialogTitle} | ||
| body={terminateDialogBody} | ||
| confirmText={terminateDialogConfirmText} | ||
| onSubmit={this.handleTerminateDeleteClick} | ||
| onError={this.handleTerminateDialogActionError} | ||
| onClose={this.handleTerminateDialogActionClose} | ||
| /> | ||
| )} | ||
| </Fragment> | ||
| )} | ||
| {worker && this.renderQueueWorker()} | ||
| {!worker && WorkerManagerWorker && this.renderWorkerManagerWorker()} |
There was a problem hiding this comment.
This is really slick! Nice! 🎉
| @@ -169,7 +169,8 @@ export default class WMViewWorkers extends Component { | |||
|
|
|||
| return ( | |||
| <Dashboard | |||
| title={`Workers for ${decodeURIComponent(params.workerPoolId)}`}> | |||
| disableTitleFormatting | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only worker-manager data is available, page no longer shows error and gives 404, but displays available info