Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces single "googleapis" with smaller packages #6926

Merged
merged 1 commit into from Apr 29, 2024

Conversation

lotas
Copy link
Contributor

@lotas lotas commented Mar 22, 2024

This will speed up startup times, as whole googleapis package is >100Mb of js/json which needs a lot of time to parse at startup.

Replacing single mono-package with smaller ones

Github Bug/Issue: Fixes #6761

@lotas lotas force-pushed the feat/6761-googleapis branch 3 times, most recently from c4d5f2b to 9f493c5 Compare April 26, 2024 11:51
@lotas lotas closed this Apr 29, 2024
@lotas lotas reopened this Apr 29, 2024
Single big `googleapis` package contained service definitions for all or
most of google services, that counted 100mb+ in source files to read
during each startup. By using smaller libraries we load only what we
need and reduce startup time
@lotas lotas marked this pull request as ready for review April 29, 2024 09:23
@lotas lotas requested a review from a team as a code owner April 29, 2024 09:23
@lotas lotas requested review from petemoore and matt-boris and removed request for a team April 29, 2024 09:23
Copy link
Contributor

@matt-boris matt-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you 👍🏻

@matt-boris matt-boris merged commit 4b9f67f into main Apr 29, 2024
73 checks passed
@matt-boris matt-boris deleted the feat/6761-googleapis branch April 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Replace googleapis package with specific ones
2 participants