Bug fix: Generic Worker: Process absolute paths in task payload correctly #6690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemoore
requested review from
lotas and
matt-boris
and removed request for
a team
|
Converting back to draft, I realise I should probably add a test or two... |
petemoore
force-pushed
the
issue6689
branch
3 times, most recently
from
b351daf
to
d7d000c
Compare
…ctly Generic Worker now evaluates absolute paths inside `mounts` (properties `directory` and `file`) and artifacts (property `path`) correctly. Previously Generic Worker would effectively strip leading path separators and treat them as relative paths inside the task directory. For example, `/tmp` would be resolved as the relative path `tmp` from inside the task directory. This has now been fixed, so that both absolute and relative paths are evaluated correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Bug/Issue: Fixes #6689