Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic-worker: add tests for mounting indexed artifacts #6271

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

petemoore
Copy link
Member

This is a follow-up from #6246 (comment)

@petemoore petemoore self-assigned this May 31, 2023
@petemoore petemoore marked this pull request as ready for review December 15, 2023 14:01
@petemoore petemoore requested a review from a team as a code owner December 15, 2023 14:01
@petemoore petemoore requested review from lotas and matt-boris and removed request for a team December 15, 2023 14:01
@petemoore
Copy link
Member Author

Note, this is just an initial indexed artifact test. It could be expanded in future to cover more test cases:

  1. that when the index is updated (new task ID) for an artifact that has already been cached, and then a task references it, that the new artifact is downloaded
  2. that when the index is not updated for an artifact that has already been cached, or is updated with e.g. a higher rank but the task ID remains the same, and a new task references the indexed artifact, that the cached artifact is used

Copy link
Contributor

@matt-boris matt-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it Pete, thanks! Only tiny nit from me is variable naming. Using payload is a bit confusing since we generally refer to payloads as the task payload. So it hurts readability just a tiny bit. Instead, maybe we could use itr for InsertTaskRequest? Wdyt?

matt-boris
matt-boris previously approved these changes Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants