feat: add azure image builder #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-boris
force-pushed
the
matt-boris/azureImageBuilder
branch
4 times, most recently
from
51ec715
to
24f8ffd
Compare
petemoore
reviewed
May 10, 2024
There was a problem hiding this comment.
This is so awesome!!! I realise it is a lot of work that packer could have done for us, but I love it that we can easily see what is going on behind the scenes. I love that we don't depend on some version of packer and its dependencies etc, and only rely on the az CLI and that there is less magic about how this instance is actually getting created and snapshotted etc. Really awesome work, Boris!
|
Also would be good to update README.md... |
matt-boris
force-pushed
the
matt-boris/azureImageBuilder
branch
10 times, most recently
from
748a9a4
to
8811f68
Compare
matt-boris
force-pushed
the
matt-boris/azureImageBuilder
branch
from
8811f68
to
a54bac8
Compare
petemoore
previously approved these changes
May 16, 2024
| apt-get install -y google-cloud-sdk | ||
| apt-get install -y google-cloud-sdk && \ | ||
| curl -sL https://aka.ms/InstallAzureCLIDeb | bash && \ | ||
| rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Do you also need to install flock here?
There was a problem hiding this comment.
Nope! Comes installed on ubuntu:22.04 :)
matt-boris
force-pushed
the
matt-boris/azureImageBuilder
branch
from
a54bac8
to
196e13f
Compare
petemoore
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #728