Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve AnsiStyle #386

Closed
wants to merge 1 commit into from
Closed

improve AnsiStyle #386

wants to merge 1 commit into from

Conversation

zoumingzhe
Copy link

@zoumingzhe zoumingzhe commented Apr 1, 2024

for example:
image

@zoumingzhe
Copy link
Author

@tartley Can you merge this patch?

@tartley
Copy link
Owner

tartley commented Apr 4, 2024

Hi there. I am terribly sorry but Colorama is not seeking to enhance it's ability to generate ANSI codes, instead preferring to focus on its core functionality of converting existing ANSI codes in the stdout/err stream into win32 calls. This is described in detail on the readme and contributing docs - apologies that they are lengthy and this is easily overlooked.

Instead, we direct users who wish to generate ANSI codes, in the way your PR facilitates, to instead use a different library that is dedicated to that purpose, such as rich, blessings, termcolor, etc, all of which do a much better job than we could ever hope to. That way each library can focus on doing one thing well.

Greatest apologies -Jonathan.

@tartley tartley closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants