Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the metadata into setup.cfg #264

Closed
wants to merge 1 commit into from

Conversation

KOLANICH
Copy link

No description provided.

@tartley
Copy link
Owner

tartley commented Oct 13, 2020

Hey. FYI, Yesterday I created a PR to test releases before we push them to PyPI. When that is merged, I'll be more confident about resuming merges and releases. I'll try to look at this PR soon. Thank you for creating it!

@tartley
Copy link
Owner

tartley commented Oct 13, 2020

I like the idea of this change. Can I ask if you have particular motivations for submitting it, other than the fun of switching to the new & much-improved syntax?

An important but presumably easily-fixable detail: The CI build failed on this branch, so it can't be accepted as-is.

I'm reading around the idea, and notice conversations like pypa/sampleproject#56,
which point out that end-users with very old versions of setuptools will not be able to install Colorama if we use this new syntax. Apparently setuptools 30.3.0, from Dec 2016, introduced the ability to use setup.cfg like this.

This doesn't rule out making the change, I just want to have the conversation, so that we all understand as best we can.

Presumably there are very few users who are stuck on such an old version of setuptools. However, Colorama is a very widely-used transitive dependency. For example, is used by 'pip'. So it seems like a bad outcome if someone stuck on an old setuptools for reasons beyond their control was unable to use 'pip' because of a change we made. I have no idea whether that scenario is realistic. Thoughts welcome.

@tartley
Copy link
Owner

tartley commented Oct 7, 2021

Hey. Huge thanks for the thought, but this branch broke CI, and hasn't been fixed, so I'm closing for now. Hugs!

@tartley tartley closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants