Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against multiple calls to init(). #236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Guard against multiple calls to init(). #236

wants to merge 3 commits into from

Commits on Nov 11, 2019

  1. Guard against multiple calls to init(). 

    BEWARE, I haven't tested this on Windows (because I
don't have a Windows box.) It should definitely get
tested there before we merge.

This should no longer lose the original stdout/stderr,
so that we can restore them with a single call to deinit(),
while still preserving the behavior that multiple calls
to init() can override the passed values for autoreset,
convert, strip, wrap.

This fix is not intended to reset output to default
foreground/background colors after the call to
'deinit()' -  that was never intended behavior.
    @tartley
    tartley committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0d55855 View commit details
    Browse the repository at this point in the history

  2. test context managers should clean up in ...finally

    @tartley
    tartley committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    66decc2 View commit details
    Browse the repository at this point in the history

  3. Fix broken assignment in deinit. 

    Add an extra test to prove that it's needed.
    @tartley
    tartley committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    16d462b View commit details
    Browse the repository at this point in the history