Merge push/pull_request CI workflows #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your pull-request, make sure the following is done.
masterso that it can be merged easily.Update changelogs/next.md with your change (include reference to the issue & this PR).Not applicableMake sure all of the significant new logic is covered by tests.Not applicableDescription
Reduce GitHub Actions jobs duplication by merging workflows for pull requests and pushes to the main branch.
With the change,
Style,TestsandSonarCloudjobs are not duplicated anymore.As the jobs to push sdist/wheels for prod and test PyPI are a bit different, for now they are separated in different jobs, but ideally we may want to have a separate workflow for publishing wheels to prod index, by for instance running it when we tag a new version (rather than always trying to push to PyPI and relying on the fact that the version is already uploaded, which can be risky).
You can see on the PR workflow that the steps for building/pushing to prod indexes are not run.