fix!: change position calculation in MTparams for mergemining #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 40m 3s ⏱️ For more details on these failures, see this check. Results for commit b4bfaa8. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 40m 24s ⏱️ For more details on these failures, see this check. Results for commit b4bfaa8. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
changed the title
SWvheerden
force-pushed
the
sw_change_mm_data_pos
branch
from
7198622
to
b4bfaa8
Compare
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the way we calculate the position of the hash from the Merkle tree params
Motivation and Context
Its possible to have the same proof for different sized merkle trees. Verification needs to verify the total size from the decoded merkle tree params
What process can a PR reviewer use to test or verify this change?
Ensure it's the same as here: https://github.com/SChernykh/p2pool/blob/2c549f61a46a5f4f0be7c631dff6e928f73a52e2/src/merkle.cpp#L341-L369