-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip]chore: fix cucumber test #6087
base: development
Are you sure you want to change the base?
Conversation
Test Results (Integration tests) 2 files + 2 11 suites +11 28m 51s ⏱️ + 28m 51s For more details on these failures, see this check. Results for commit a58cff4. ± Comparison against base commit b48a830. ♻️ This comment has been updated with latest results. |
Test Results (CI) 3 files 120 suites 33m 21s ⏱️ Results for commit a58cff4. ♻️ This comment has been updated with latest results. |
// fs::create_dir_all(&test_run_dir).unwrap(); | ||
// | ||
// for entry in fs::read_dir(log_dir).unwrap() { | ||
// let file = entry.unwrap(); | ||
// fs::copy(file.path(), test_run_dir.join(file.file_name())).unwrap(); | ||
// fs::remove_file(file.path()).unwrap(); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this? Is it because of unwrap
failing the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, same question here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is related
Description
makes the last log, a best effort.
If the mutex is held in a another thread which is sometimes is, the lock will fail, failing the entire test, and its just a logging issue.