-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace tui with ratatui #5650
base: development
Are you sure you want to change the base?
Conversation
After updating the launchpad, I saw that it's an opportune moment to implement the same changes here, given today's minimal alterations. |
Test Results (Integration tests) 2 files + 2 11 suites +11 27m 32s ⏱️ + 27m 32s For more details on these failures, see this check. Results for commit b90bfe9. ± Comparison against base commit 08ba91a. ♻️ This comment has been updated with latest results. |
33e3f84
to
330109c
Compare
330109c
to
b90bfe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on windows, but it skips every second tab when I press left and right |
On Windows, the duplicate key issue is due to a new feature in Crossterm. You want to make sure you check for the - CrosstermEvent::Key(e) => tx.send(Event::Key(e)),
+ CrosstermEvent::Key(key) => {
+ if key.kind == KeyEventKind::Press {
+ tx.send(Event::Key(key));
+ }
+ }, For relevant information here: ratatui-org/ratatui#347 and here: https://ratatui.rs/faq/#why-am-i-getting-duplicate-key-events-on-windows |
Description
Switch from the
tui
crate toratatui
.Motivation and Context
The tui crate is no longer actively maintained. Fixes #5618
How Has This Been Tested?
CI