Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Redis Versioning #143

Merged
merged 2 commits into from Nov 20, 2020
Merged

Bug Fix: Redis Versioning #143

merged 2 commits into from Nov 20, 2020

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Nov 20, 2020

Describe the change
The dependency go-redis for strelka-frontend and strelka-manager has recently been updated, which caused issues in compilation of the strelka cluster (redis/go-redis#1534). A fix has been implemented to use a previous release of go-redis (v8). While this should act as a fix, it should also be temporary until an alternative solution has been identified or go-redis fixes this issue.

Related Issue: #142

Describe testing procedures

  • Destroyed and rebuilt all strelka images to identify additional errors.
  • Ran multiple scanners to identify additional errors and review output changes.

Sample output
No output changes.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Paul Hutelmyer added 2 commits November 20, 2020 10:57
Updated redis module (>8) breaks. Pinning module to version 8. This should be a temporary fix until proper fix is implemented.
@phutelmyer phutelmyer changed the title Redis fix versioning Bug Fix: Redis Versioning Nov 20, 2020
@phutelmyer phutelmyer merged commit 4b4f412 into master Nov 20, 2020
@phutelmyer phutelmyer added the bug Something isn't working label Jan 13, 2021
@phutelmyer phutelmyer deleted the redis-fix-versioning branch February 24, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant