Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Jinja version #1938

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Pin Jinja version #1938

merged 2 commits into from
Mar 28, 2022

Conversation

isaacgsmith
Copy link
Member

Description

Pins Jinja2 to version 3.0.3.

Motivation and context

The new release of Jinja2 breaks the documentation build pipeline. See spatialaudio/nbsphinx#641.

How has this been tested?

  • Testing pipeline.
  • Documentation built on GitHub.

Examples

Before: https://github.com/smithis7/tardis/actions/runs/2048909458
After: https://github.com/smithis7/tardis/actions/runs/2048920639

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #1938 (3a22593) into master (e7c2ec3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1938   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files          70       70           
  Lines        7843     7843           
=======================================
  Hits         4609     4609           
  Misses       3234     3234           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andrewfullard andrewfullard merged commit b30602e into tardis-sn:master Mar 28, 2022
@isaacgsmith isaacgsmith deleted the jinja_pin branch March 28, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants