Components don't work properly in iframe #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @tianxiumei. I've added another commit which is a tweaked version of the change you'd already made. If you're happy with it I'll squash the commits and merge 🙏 |
|
Can't unit test this properly using jsdom - needs a real browser - so will likely merge without that additional test. Update: Looking at a Playwright test for this scenario. |
tanem
force-pushed
the
ifram_bug
branch
3 times, most recently
from
f5fffad
to
216fa73
Compare
|
Dropping playwright tests for this PR, will add in another PR at a later date as it needs a bit more thought. |
|
Merged, thanks for the PR! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.