Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for unicode ranges larger than 0xFFFF #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for unicode ranges larger than 0xFFFF #507

wants to merge 1 commit into from

Conversation

MLoughry
Copy link

@MLoughry MLoughry commented Feb 8, 2023

Fixes #361

@MLoughry MLoughry changed the title Add support for unicode ranges larger than 0xFFF Add support for unicode ranges larger than 0xFFFF Feb 8, 2023
@MLoughry
Copy link
Author

MLoughry commented Feb 9, 2023

@tancredi, would love a review on this one-line fix.

Currently, fantasticon doesn't correctly support code points greater than 0xFFFF, because String.prototype.charCodeAt() only supports UTF-16 code points, whereas String.prototype.codePointAt supports all Unicode code points. This is necessary to reach the private use areas in the ranges U+F0000..U+FFFFD and U+100000..U+10FFFD, which is necessary when creating icon fonts with more than 6400 glyphs.

@MLoughry MLoughry mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancredi tancredi Awaiting requested review from tancredi tancredi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for unicode codepoints greater than 0xffff
1 participant
@MLoughry