add fontsUrlHash to options to avoid adding extra hash parameters to url function #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some developers are using this package for build and commit result to the repository
nasserghiasi
changed the title
|
Any Progress on this PR? It is exactly my problem now. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful when a developer wants to build icons through the webpack build process or git hooks and commit the output.
But in the current state of the repository developers, cant prevent adding hash parameters to the output CSS or SCSS file and on each running of build those parameters will change and developers should be careful about that changes and revert them. So this is annoying.
Before:
@font-face { font-family: $icons-font; src: url('./icon-font.woff2?6b5eab133ec268cf9627ede6bfc39908') format('woff2'), url('./icon-font.woff?6b5eab133ec268cf9627ede6bfc39908') format('woff'); }After:
@font-face { font-family: $icons-font; src: url('./icon-font.woff2?') format('woff2'), url('./icon-font.woff?') format('woff'); }