Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for specifying codepoints as hex strings #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lknop
Copy link
Contributor

@lknop lknop commented Mar 9, 2021

The usual notation for codepoint map is hex, which is not compatible with json by default. This PR adds support for hex string values for codepoints which are then parsed into appropriate numeric values.

The same config file can use multiple notations interchangeably:

codepoints: {
  'arrow-out': 57344,
  'exclamation-circle':'\e00d',
  'arrow-down': '0xe01d'
}

@lknop lknop requested a review from tancredi as a code owner March 9, 2021 07:02
@tancredi
Copy link
Owner

Hi @lknop - thank you so much for the PR! Would it be possible to have a test or two to go with it, and maybe a couple lines of example in the Readme, as you've done for numeric values? :)

@lknop
Copy link
Contributor Author

lknop commented Mar 17, 2021

@tancredi Sure, I will add those. I just wanted some feedback whether the change would be welcome, I should be able to push an update in the next few days.

@tancredi
Copy link
Owner

Amazing - thanks! Yes I'd say it is!

@mmoollllee
Copy link

Would love to see this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants