poc: Fix Basic Vite Support #2286
Conversation
|
@bnussman is attempting to deploy a commit to the Tamagui Team on Vercel. A member of the Team first needs to authorize it. |
|
New dependencies detected. Learn more about Socket for GitHub 鈫楋笌
|
| // https://vitejs.dev/config/ | ||
| export default defineConfig({ | ||
| define: { | ||
| 'process.env.TAMAGUI_BAIL_AFTER_SCANNING_X_CSS_RULES': false, |
There was a problem hiding this comment.
Somethig is going to have to be done with process.env.TAMAGUI_BAIL_AFTER_SCANNING_X_CSS_RULES in insetStyleRule.tsx. This won't work in the browser
I tried removing it but that package would break when it was rebuilt.
There was a problem hiding this comment.
I'm not sure what to do about import.meta.env. Webpack doesn't support it:
So you're sort of stuck. It's actually a bit wild that we have the two most popular bundlers set up in a way that you can't really access env without some really weird hacks.
I think I've done something like typeof import.meta !== 'undefined' ? import.meta.env.X : process.env.X before.
There was a problem hiding this comment.
This solved the main problem
There was a problem hiding this comment.
My goal was to see what it would take to tamagui without any plugins.
These changes in this file allowed me to do so.
There was a problem hiding this comment.
I created this vite app just for testing.
|
Merged on another branch :) |
Description 馃摑
This is a POC that shows how
@tamagui/config/v3is broken for ViteThe main two issues with basic Vite support are
process.env.TAMAGUI_BAIL_AFTER_SCANNING_X_CSS_RULESmakes Vite dev mode not work@tamagui/config/v3exports react native code I think?Before
After
Screencast.from.02-17-2024.11.41.30.AM.webm