Update TestProvideSnap2C in raft_test.go #425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`handleSnapshot` only affects states in raft, not affects states in storage. More specifically, the snapshot in memory storage will be as it is after `handleSnapshot`. As a result, when leader is willing to send a snapshot to follower, it is the empty snapshot being sent. However, in my implementation, such a sending will be aborted since the snapshot is empty. Therefore, this test fails. Sending an empty snapshot is definitely shall be rejected, and I update the test case to not confuse ones like me.
Connor1996
reviewed
Sep 6, 2022
|
In etcd's implementation, a panic is raised if the storage gives back an empty snapshot. A snapshot is regarded empty if its metadata index is 0. |
|
I misunderstood the meaning of empty snap. As expected, you shouldn't return the init snap for MemStorage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleSnapshotonly affects states in raft, not affects states in storage. More specifically, the snapshot in memory storage will be as it is afterhandleSnapshot. As a result, when leader is willing to send a snapshot to follower, it is the empty snapshot being sent.However, in my implementation, such a sending will be aborted since the snapshot is empty. Therefore, this test fails.
Sending an empty snapshot is definitely shall be rejected, and I update the test case to not confuse ones like me.