Skip to content

Commit

Permalink
fix(to issue#455): fix a typo (#456)
Browse files Browse the repository at this point in the history
I am recently debugging at 3B. And when I am reading the Destroy function at file kv/raftstore/peer.go, I found that there is a comment "write kv rocksdb first in case of restart happen between two write".
The previous lab in tinykv seems never mention about rocksdb, while the TiKV mentioned. So I think there is a typo, and this comment should be modified to "write kv badgerDB first in case of restart happen between two write".
  • Loading branch information
elephas00 committed Mar 15, 2024
1 parent 86a0b62 commit 1338f1b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kv/raftstore/peer.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (p *peer) Destroy(engine *engine_util.Engines, keepData bool) error {
return err
}
meta.WriteRegionState(kvWB, region, rspb.PeerState_Tombstone)
// write kv rocksdb first in case of restart happen between two write
// write kv badgerDB first in case of restart happen between two write
if err := kvWB.WriteToDB(engine.Kv); err != nil {
return err
}
Expand Down

0 comments on commit 1338f1b

Please sign in to comment.