Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps dependencies to get rid old version of ring (<0.17) #248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bumps dependencies to get rid old version of ring (<0.17) #248

wants to merge 3 commits into from

Conversation

sr-gi
Copy link
Member

@sr-gi sr-gi commented Dec 29, 2023 •
edited

rcgen was using version 0.8 which used a ring version that didn't support ppc64le arch. Support for it was recently added in ring=0.17.0 and supported by rcgen in 0.12

tonic also had a chain dependency to ring, so it needed updating (and therefore also prost)

Close #243

@sr-gi sr-gi mentioned this pull request Dec 29, 2023
Open
mariocynicys
mariocynicys requested changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the linting issue, looks good 👍 .

@sr-gi
Copy link
Member Author

sr-gi commented Dec 30, 2023

Looks like we may need to pause this for a bit more. tonic also has a dependency chain to ring

@sr-gi sr-gi changed the title Bumps rcgen version to 0.12, adapts tls.rs accordingly Bumps dependencies to get rid old version of ring (<0.17) Mar 20, 2024
@sr-gi
Copy link
Member Author

sr-gi commented Mar 20, 2024

Made some progress updating tonic. We still have a last dependency to an old ring version from using x509-parser. However, looks like they are about to cut a release bumping their deps.

rustls/rcgen#236

@sr-gi sr-gi force-pushed the bump-rcgen branch 4 times, most recently from fc3b9be to 8e9e451 Compare March 20, 2024 19:39
@sr-gi sr-gi force-pushed the bump-rcgen branch 2 times, most recently from ae15222 to 54aea52 Compare March 28, 2024 09:10
@sr-gi sr-gi mentioned this pull request Mar 28, 2024
Open
@sr-gi
Bumps rcgen version to 0.12, adapts tls.rs accordingly
ecfaf19 
rcgen was using version 0.8 which used a ring version that didn't support
ppc64le arch. Support for it was recently added in ring=0.17.0 and supported by
rcgen in 0.12
@sr-gi
Bumps tonic to 0.11 and prost to 0.12, adapts Cargo files accordingly
e8f2b01 
Bumping tonic required cargo file edition to be bumped to 2021
@sr-gi
gh-actions: make sure protoc is installed when installing teos
d30de67 
This is a temp fix, the installation usually happens when creating the cache,
so we can remove this after creating a new one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocynicys mariocynicys mariocynicys requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump ring dependency to 0.17.0
2 participants
@sr-gi @mariocynicys