Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing PostCSS dependencies in the CLI #9617

Merged
merged 5 commits into from Oct 20, 2022
Merged

Fix missing PostCSS dependencies in the CLI #9617

merged 5 commits into from Oct 20, 2022

Commits on Oct 20, 2022

  1. Record and watch PostCSS dependencies in the CLI

    @thecrypticace @RobinMalfait
    thecrypticace authored and RobinMalfait committed Oct 20, 2022
    Copy the full SHA
    955f968 View commit details
    Browse the repository at this point in the history

  2. ensure changedContent gets cleared 

    Otherwise this list gets bigger and bigger, not only that there is a
subtle bug. The moment you save a `.css` file we want to create a new
context and start from scratch. However, since the list was never
cleared, it meant that every subsequent save to *any* file (not only
config / css files) creates a new context...

By clearing the least we should work around this problem.
    @RobinMalfait
    RobinMalfait committed Oct 20, 2022
    Copy the full SHA
    1a15f22 View commit details
    Browse the repository at this point in the history

  3. add test that verifies an odd bug 

    The story goes like this:

1. add `underline` to html file
  -> css contains `underline` rule
2. add `font-bold` to html file
  -> css contains `underline` and `font-bold`
3. remove `underline` from html file
  -> css still contains `underline` and `font-bold` for performance reasons
4. Save a css file (! RED FLAG)
  -> css contains `font-bold` because we started from scratch
5. add `underline` to html file
  -> css contains `underline` and `font-bold`
6. remove `underline` from html file
  -> css only contains `font-bold`... (UH OH)

This is because the moment we did step 4, every single save in any file created a new context. Every. Single. Time.
    @RobinMalfait
    RobinMalfait committed Oct 20, 2022
    Copy the full SHA
    d6625eb View commit details
    Browse the repository at this point in the history

  4. use a property that doesn't require autoprefixer

    @RobinMalfait
    RobinMalfait committed Oct 20, 2022
    Copy the full SHA
    c426d10 View commit details
    Browse the repository at this point in the history

  5. update changelog

    @RobinMalfait
    RobinMalfait committed Oct 20, 2022
    Copy the full SHA
    33f0513 View commit details
    Browse the repository at this point in the history