Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DEFAULT is taken into account for matchVariant #9603

Merged
merged 1 commit into from Oct 18, 2022

Commits on Oct 18, 2022

  1. ensure DEFAULT is taken into account for matchVariant

    This means that if you define your `matchVariant` as:
    
    ```js
    matchVariant('foo', (value) => '.foo-${value} &')
    ```
    
    Then you can't use `foo:underline`, if you want to be able to use
    `foo:underline` then you have to define a `DEFAULT` value:
    
    ```js
    matchVariant('foo', (value) => '.foo-${value} &', {
      values: {
        DEFAULT: 'bar'
      }
    })
    ```
    
    Now `foo:underline` will generate `.foo-bar &` as a selector!
    RobinMalfait committed Oct 18, 2022
    Copy the full SHA
    0f451af View commit details
    Browse the repository at this point in the history