Add a from when postcss parsing preflight
#7369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyming
changed the title
from when postcss parsing preflight
|
Thanks! Gonna take a look at this either today or tomorrow as I'll be making a few fixes to source map generation. |
|
Thanks for the PR! In the end the real issue ended up being elsewhere — we are supposed to overwrite the source on all nodes even those produced by plugins and were not doing so recursively so there were a lot of lines that didn't have source maps attached. This did however lead me to discover that we weren't setting some stuff up correctly so I really appreciate it! |
|
Awesome, thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was tracking down today why builds for some of our apps were not deterministic. I believe it's because no
fromis provided topostcss.parse, so it generates a random ID every compilation. I am out of my depth with frontend tooling, so I wasn't sure how thisfromvalue is used and if what I've done is appropriate. Regardless, I believe it should be something stable and non-null.See postcss/postcss#1512 and #3356 for a related issue and discussion.
Fixes #7583