Cleanup leftover layers #4853
Merged
Cleanup leftover layers #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
cleanup-leftover-layers
branch
from
07d93e2
to
5bd2425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create the context we also collect all the
@layernodes, cache them and remove them from the final stylesheet. However once you are in a running process the context will only be created once (as long as the dependencies don't change). Therefore the@layernodes are not collected and removed anymore.We already inject the correct contents (because we had it cached) but we didn't cleanup leftover
@layerrules. This PR will make sure that we do that cleanup.Whenever somebody changes the contents of an
@layer, then one of the dependencies changed and a new context is created, therefore the new contents will be handled correctly.Fixes: #4851