Disable dark mode by default, rename config option to darkMode
#2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
26 tasks
This was referenced Mar 15, 2021
Update tailwindcss requirement from ^2.0.3 to ^2.0.4
stephenlaichaowen/vite-vue3-tailwind-starter#17
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables dark mode by default because of the affect it has on the default build size. The config stubs include
darkMode: falseby default though which can easily be changed to'media'if the user wants dark mode variants enabled.I've also changed the name of the config option from simply
darktodarkModebecause I think it's a bit clearer. Minor breaking change for anyone using the experimental version but 500ms to update.