Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle group/peer variants with quoted strings #10400

Merged
merged 7 commits into from Jan 23, 2023
Merged

Handle group/peer variants with quoted strings #10400

merged 7 commits into from Jan 23, 2023

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Jan 23, 2023 •
edited

Fixes #10353

This fixes two issues:

  1. We were splitting on / in a quoted string in group/peer variants
  2. We were splitting not-a-space but should've consumed spaces inside quoted string in group/peer variants.

RobinMalfait
RobinMalfait approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

src/lib/generateRules.js Outdated Show resolved Hide resolved
src/corePlugins.js Outdated Show resolved Hide resolved
tests/basic-usage.test.js Show resolved Hide resolved
tests/util/run.js Outdated Show resolved Hide resolved
thecrypticace and others added 3 commits January 23, 2023 12:39
@thecrypticace
Use splitAtTopLevelOnly instead
ecdffb2 
This solution isn’t that pretty but it is reusing existing machinery
@thecrypticace @RobinMalfait
inline return
dd7c01f 
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
@thecrypticace @RobinMalfait
Fix return type
4e1d6e4 
Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
@thecrypticace thecrypticace merged commit f821c71 into master Jan 23, 2023
@thecrypticace thecrypticace deleted the fix/group-peer-quoted-strings branch January 23, 2023 18:37
@thecrypticace thecrypticace mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait RobinMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

double escape happening in attribute value selectors
2 participants
@thecrypticace @RobinMalfait