Skip to content

Commit

Permalink
Don't apply margins to <br> elements contained in an <li> in FF (#…
Browse files Browse the repository at this point in the history
…350)

* Only fixup margins in `p` tags when inside a list item

The intent of these selectors are to only target `p` tags but we are targeting `*:first-child` and `*:last-child`. This has a side effect of causing `<br>` elements inside the list item to gain a margin _only in Firefox_. Other browsers treat the `<br>` element as properly inline and as such don’t apply margins but FF does not seem to.

* Update changelog
  • Loading branch information
thecrypticace committed Apr 24, 2024
1 parent cacc7dc commit c0dea6c
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 21 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Expand Up @@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Nothing yet!
### Fixed

- Don't apply margins to `<br>` elements contained in an `<li>` in FF ([#350](https://github.com/tailwindlabs/tailwindcss-typography/pull/350))

## [0.5.12] - 2024-03-27

Expand Down
40 changes: 20 additions & 20 deletions src/styles.js
Expand Up @@ -128,16 +128,16 @@ let defaultModifiers = {
marginTop: em(8, 14),
marginBottom: em(8, 14),
},
'> ul > li > *:first-child': {
'> ul > li > p:first-child': {
marginTop: em(16, 14),
},
'> ul > li > *:last-child': {
'> ul > li > p:last-child': {
marginBottom: em(16, 14),
},
'> ol > li > *:first-child': {
'> ol > li > p:first-child': {
marginTop: em(16, 14),
},
'> ol > li > *:last-child': {
'> ol > li > p:last-child': {
marginBottom: em(16, 14),
},
'ul ul, ul ol, ol ul, ol ol': {
Expand Down Expand Up @@ -333,16 +333,16 @@ let defaultModifiers = {
marginTop: em(12, 16),
marginBottom: em(12, 16),
},
'> ul > li > *:first-child': {
'> ul > li > p:first-child': {
marginTop: em(20, 16),
},
'> ul > li > *:last-child': {
'> ul > li > p:last-child': {
marginBottom: em(20, 16),
},
'> ol > li > *:first-child': {
'> ol > li > p:first-child': {
marginTop: em(20, 16),
},
'> ol > li > *:last-child': {
'> ol > li > p:last-child': {
marginBottom: em(20, 16),
},
'ul ul, ul ol, ol ul, ol ol': {
Expand Down Expand Up @@ -538,16 +538,16 @@ let defaultModifiers = {
marginTop: em(16, 18),
marginBottom: em(16, 18),
},
'> ul > li > *:first-child': {
'> ul > li > p:first-child': {
marginTop: em(24, 18),
},
'> ul > li > *:last-child': {
'> ul > li > p:last-child': {
marginBottom: em(24, 18),
},
'> ol > li > *:first-child': {
'> ol > li > p:first-child': {
marginTop: em(24, 18),
},
'> ol > li > *:last-child': {
'> ol > li > p:last-child': {
marginBottom: em(24, 18),
},
'ul ul, ul ol, ol ul, ol ol': {
Expand Down Expand Up @@ -743,16 +743,16 @@ let defaultModifiers = {
marginTop: em(16, 20),
marginBottom: em(16, 20),
},
'> ul > li > *:first-child': {
'> ul > li > p:first-child': {
marginTop: em(24, 20),
},
'> ul > li > *:last-child': {
'> ul > li > p:last-child': {
marginBottom: em(24, 20),
},
'> ol > li > *:first-child': {
'> ol > li > p:first-child': {
marginTop: em(24, 20),
},
'> ol > li > *:last-child': {
'> ol > li > p:last-child': {
marginBottom: em(24, 20),
},
'ul ul, ul ol, ol ul, ol ol': {
Expand Down Expand Up @@ -948,16 +948,16 @@ let defaultModifiers = {
marginTop: em(20, 24),
marginBottom: em(20, 24),
},
'> ul > li > *:first-child': {
'> ul > li > p:first-child': {
marginTop: em(32, 24),
},
'> ul > li > *:last-child': {
'> ul > li > p:last-child': {
marginBottom: em(32, 24),
},
'> ol > li > *:first-child': {
'> ol > li > p:first-child': {
marginTop: em(32, 24),
},
'> ol > li > *:last-child': {
'> ol > li > p:last-child': {
marginBottom: em(32, 24),
},
'ul ul, ul ol, ol ul, ol ol': {
Expand Down

0 comments on commit c0dea6c

Please sign in to comment.