Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo breaking background colors on checkboxes & radio buttons #72

Merged
merged 1 commit into from Jun 3, 2021

Conversation

chasegiunta
Copy link
Contributor

@chasegiunta chasegiunta commented Jun 1, 2021

Totally my fault on this one for the bad previous PR... Apologies.

Just in case anyone has reported this or similar:
This typo really rears it's ugly head when using some postcss optimizations that combine style declarations (cssnano, perhaps?), thus breaking the background colors for checkboxes & radio buttons when using the class strategy.

Attempting to merge styles like this:

.form-checkbox:checked, .form-radio:checked {
    border-color: transparent;
    background-color: currentColor;
    background-size: 100% 100%;
    background-position: center;
    background-repeat: no-repeat;
}

into others like so:

.form-checkbox:checked,.form-checkbox:checked:focus,.form-checkbox:checked:hover,.form-checkbox:indeterminate,.form-checkbox:indeterminate:focus,.form-checkbox:indeterminate:hover,.form-radio:check:focus,.form-radio:checked,.form-radio:checked:hover {
    border-color: transparent;
    background-color: currentColor;
}

Completely breaking the entire rule.

@vercel
Copy link

vercel bot commented Jun 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tailwindlabs/tailwindcss-forms/6Y8N2dSqkeP46pMBkNQ3vtBWmBcF
✅ Preview: https://tailwindcss-forms-git-fork-chasegiunta-master-tailwindlabs.vercel.app

@chasegiunta chasegiunta changed the title Fix typo preventing background colors on checkboxes & radio buttons Fix typo breaking background colors on checkboxes & radio buttons Jun 1, 2021
@adamwathan adamwathan merged commit 1f0a7c8 into tailwindlabs:master Jun 3, 2021
@adamwathan
Copy link
Member

Thanks! Tagged a new release.

@chasegiunta
Copy link
Contributor Author

@alexandregiordanelli This doesn't look like the same bug. Something else is going on there.

@alexandregiordanelli
Copy link

@alexandregiordanelli This doesn't look like the same bug. Something else is going on there.

sorry, the tailwind doesnt detect a checkbox on prod env, I solved putting a checkbox hidden and the processor could solve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants